-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting and Pytests #63
base: master
Are you sure you want to change the base?
Conversation
maxmarzolf
commented
Apr 30, 2021
- Added urllib3 to requirements.txt
- Abbreviated props dictionary creation as dictionary literal in utility.py
- Fixed typo in get_explanation function
- Made formatting PEP 8 compliant
- Added urllib3 to requirements.txt - Abbreviated props dictionary creation as dictionary literal in utility.py - Fixed typo in get_explanation function - Made formatting PEP 8 compliant
Can you explain all the changes to the requirements.txt file. It isn't just the addition of urllib3. |
hmm I only intended to add urllib3, not sure why more than that was changed :) |
Removing unnecessary packages unique to my environment.
Would be happy to put more work in, thanks. |
This PR has been open for more than 1.5 years. Is it still relevant ? |
I think so, the last sentence in the readme says, "If you would like to contribute, right now we could use some attention to the tests." which is what this PR aims to develop. |